-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set MULTI_RESULTS and MULTI_STATEMENTS MySQL client CAP #12690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smallinsky Any reason why we hardcode the options instead of forwarding them from the client? AFAIR we're already doing something similar with Postgres, so it shouldn't be hard to implement.
The client cap are obtained in teleport proxy where connection to upstream server is done in teleport db agent. Teleport agent and proxy speaks raw TCP thus right now the only way to propagate client capability is to encode them in client TLS identity. |
@smallinsky See the table below for backport results.
|
What
Preset
CLIENT_MULTI_RESULTS
andCLIENT_MULTI_STATEMENTS
client capabilities when connecting to mysql instance.Why
Those caps requested and set to
conn.SetCapability()
https://github.com/gravitational/go-mysql/blob/smallinsky/v1.5.0-teleport.1/client/auth.go#L181 function to take effect.