Reverts "Fix kubernetes_service nil ptr dereference #9788" #12681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
added a commit
that referenced
this pull request
May 17, 2022
tigrato
added a commit
that referenced
this pull request
May 17, 2022
This was referenced May 17, 2022
Closed
lxea
approved these changes
May 24, 2022
tigrato
force-pushed
the
tigrato/fix-kubeconfig-missing-ca
branch
from
e410fbc to
805d834
Compare
This was referenced May 24, 2022
r0mant
pushed a commit
that referenced
this pull request
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When K8S cluster is signed with a trusted CA
kubeconfigdoes not requirecertificate-authority-dataorinsecure-skip-tls-verify)leading intotlsConfigbeingnilwhen using therest.TLSConfigForfunction.nilis a valid value fortlsConfigand it is interpreted as: use the system default CA pool and TLS config if required.This MR reverts the previous commits introduced by #9788 and removes the possible dereferences of
tlsConfigwithout sanity checks that previously were causing the panics.Fixes #12652
Reproduce steps:
--cert-expiration=8760harg in order to generate a certificate that is lower than 2.5y (possibly requires cleanup of old minikube certs)~/.minikube/ca.crtinto your system CA poolcertificate-authority-datafrom teleport'skubeconfig