[v9] Add Session tracker to DB, App, and Windows Desktop Sessions#12611
Merged
Conversation
github-actions
Bot
added
application-access
audit-log
codingllama
reviewed
May 12, 2022
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Did you have to do any noteworthy adaptations or did it backport cleanly?
Contributor
Author
It should have backported cleanly, but I had to run |
API_IMPORT_PATH is consistently being resolved as an empty string, breaking proto generation. Since the path is fixed, it seems simpler to read api/go.mod and do away with the Go program. * Explicitly set API_IMPORT_PATH * Delete the print-import-path program * Read api module from api/go.mod, push variables to target
Joerger
force-pushed
the
joerger/v9/track-all-sessions
branch
from
1d7fde0 to
3b3f925
Compare
Contributor
Author
|
@codingllama I just had to include the fix for |
xacrimon
approved these changes
May 12, 2022
codingllama
approved these changes
May 12, 2022
Contributor
Right, completely forgot about that. Thanks for pulling it in. |
zmb3
approved these changes
May 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #12304
Backports #10478 (
make grpcfix)