Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listener hygiene #12540

Merged
merged 7 commits into from
May 17, 2022
Merged

Listener hygiene #12540

merged 7 commits into from
May 17, 2022

Conversation

espadolini
Copy link
Contributor

@espadolini espadolini commented May 10, 2022

Additional server-side fixes to #11802, the biggest one being making sure that nothing in the TLS/ALPN routing machinery can actually leave a connection hanging, which causes connectivity issues during restarts, because our client code sometimes issues network calls with no timeouts.

@espadolini espadolini requested a review from smallinsky May 10, 2022 14:23
@espadolini espadolini marked this pull request as ready for review May 10, 2022 14:23
@github-actions github-actions bot requested review from strideynet and zmb3 May 10, 2022 14:23
lib/service/service.go Outdated Show resolved Hide resolved
lib/srv/alpnproxy/listener.go Show resolved Hide resolved
lib/service/service.go Show resolved Hide resolved
lib/service/signals.go Outdated Show resolved Hide resolved
@espadolini espadolini enabled auto-merge (squash) May 17, 2022 08:06
@espadolini espadolini merged commit 875dcf7 into master May 17, 2022
@github-actions
Copy link

@espadolini See the table below for backport results.

Branch Result
branch/v7 Failed
branch/v8 Failed
branch/v9 Create PR

@espadolini espadolini deleted the espadolini/listener-hygiene branch May 17, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants