Disable ssh_service for app configs
#12520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
approved these changes
May 9, 2022
stevenGravy
approved these changes
May 9, 2022
LKozlowski
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the
ssh_servicefrom the config file generated by the auto-install scripts for apps.Recently, some changes were made and the token generated by the web UI to use with the auto-install script now allows only the
approle, instead of bothappandnode. This caused the script to log errors since the agent tries to join with an unauthorized role.The script is working and adding the app, but it logs errors.
See #12514 (comment) for some details.
Needs backporting to v9
Closes #12514