Ev/tctl #1248
Merged
Ev/tctl #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontsevoy
force-pushed
the
ev/tctl
branch
3 times, most recently
from
d033e44 to
7178cb7
Compare
This commit refs #1137 - tctl get user/joe now works (as reported in #1247) - tctl create/rm roles changes - added synonyms for various resources - made YAML the default output for tctl get - added better help + examples for tctl get - edited error messages - minor refactoring - added the system of "command plugins" which allows enterprise version of tctl to introduce different behavior to OSS commands
klizhentas
reviewed
Sep 4, 2017
| @@ -215,33 +198,38 @@ func (u *ResourceCommand) Create(client *auth.TunClient) error { | |||
| case "": | |||
| return trace.BadParameter("missing resource kind") | |||
| default: | |||
| return trace.BadParameter("%q is not supported", raw.Kind) | |||
| // customized creation: | |||
| if u.Impl != nil && u.Impl.Create != nil { | |||
There was a problem hiding this comment.
I think using interfaces would be more elegant here as you won't need to check this for Nil, simply provide default interface
There was a problem hiding this comment.
but how would you customize just one method? interface would force to you create a bunch of do-nothing stubs with "ErrorNotImpl" or something... so this would be trading inconvenience in one place (here) for multiple inconveniences down the road. basically I went with Roma's suggestion here. The question of idiomatic golang's version of "subclass & override one method" is still in the air for me...
klizhentas
approved these changes
Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tctl changes (polish for 2.3), refs #1137
tctl users lsworks differently for OSS-vs-Enterprise (and matches the docs again)tctlto modify default behavior.Related PR