Wire touch ID login and registration to tsh #12475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tsh
|
Branched from #12436, target switches to master automatically once it lands. |
codingllama
force-pushed
the
codingllama/touchid-register
branch
from
a16d082 to
8d17020
Compare
codingllama
force-pushed
the
codingllama/touchid-tsh
branch
from
4dd02a4 to
3480211
Compare
codingllama
force-pushed
the
codingllama/touchid-register
branch
from
e587877 to
c0d054f
Compare
codingllama
force-pushed
the
codingllama/touchid-tsh
branch
from
3480211 to
e9af7b0
Compare
nklaassen
approved these changes
May 6, 2022
|
Friendly ping @lxea. |
lxea
approved these changes
May 7, 2022
codingllama
force-pushed
the
codingllama/touchid-register
branch
from
c0d054f to
8148bdf
Compare
codingllama
force-pushed
the
codingllama/touchid-tsh
branch
from
e9af7b0 to
a1ea67b
Compare
codingllama
force-pushed
the
codingllama/touchid-tsh
branch
from
a1ea67b to
12867fa
Compare
codingllama
added a commit
that referenced
this pull request
Jun 23, 2022
Reinstates some logic that was removed on #12475 and changes `optsOverride` to a function, so there is less ambiguity in dealing with booleans / default values. * Pass proxy address to PromptMFAChallenge calls * Add coverage for TeleportClient.PromptMFAChallenge
codingllama
added a commit
that referenced
this pull request
Jun 24, 2022
Reinstates some logic that was removed on #12475 and changes `optsOverride` to a function, so there is less ambiguity in dealing with booleans / default values. * Pass proxy address to PromptMFAChallenge calls * Add coverage for TeleportClient.PromptMFAChallenge
codingllama
added a commit
that referenced
this pull request
Jun 24, 2022
Reinstates some logic that was removed on #12475 and changes `optsOverride` to a function, so there is less ambiguity in dealing with booleans / default values. * Pass proxy address to PromptMFAChallenge calls * Add coverage for TeleportClient.PromptMFAChallenge
codingllama
added a commit
that referenced
this pull request
Jun 24, 2022
Pass proxy address to PromptMFAChallenge calls (#13772) Reinstates some logic that was removed on #12475 and changes `optsOverride` to a function, so there is less ambiguity in dealing with booleans / default values. * Pass proxy address to PromptMFAChallenge calls * Add coverage for TeleportClient.PromptMFAChallenge
codingllama
added a commit
that referenced
this pull request
Jun 24, 2022
Pass proxy address to PromptMFAChallenge calls (#13772) Reinstates some logic that was removed on #12475 and changes `optsOverride` to a function, so there is less ambiguity in dealing with booleans / default values. * Pass proxy address to PromptMFAChallenge calls * Add coverage for TeleportClient.PromptMFAChallenge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
--mfa-modeflag and wire touch ID into tsh authn/registration.In the default MFA mode (auto), touch ID should be eager if there is a credential present in the system. Users may change this behavior using other MFA modes.
See https://github.com/gravitational/teleport/blob/master/rfd/0054-passwordless-macos.md.
#9160