Gracefully degrade tsh db ls in case fetching roles fails.
#12318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tsh
smallinsky
approved these changes
Apr 29, 2022
ravicious
approved these changes
Apr 29, 2022
This was referenced Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing the remote clusters, a user may get a different set of roles and traits than in the original cluster. This can cause the code to fail to fetch the set of applicable roles, which breaks the entire command. As a stop-gap measure this PR changes that behavior to a graceful degradation where we don't calculate the available user names and show
(unknown)instead.The complete fix is proposed in #12281, but it requires discussion about the proper way to fix the issue.
Fixes #12239
Caused by #10458