Limit Kubernetes connections #12275
Limit Kubernetes connections #12275
Conversation
integration/kube_integration_test.go
Outdated
| // Create and maintain the maximum amount of open connections | ||
| errors := make(chan error) | ||
| for i := 0; i < maxConnections; i++ { | ||
| go func() { |
There was a problem hiding this comment.
Maybe we should have a waitgroup here to wait for all the intended sessions to be opened?
There was a problem hiding this comment.
Added a check so that we wait until all sessions are open.
|
|
||
| // MaxKubernetesConnections defines the maximum number of concurrent | ||
| // Kubernetes sessions a user may hold. | ||
| int64 MaxKubernetesConnections = 18 |
There was a problem hiding this comment.
It's more of an question rather than an issue, but do we have any guidelines for using specific scalar value types inside protobuf types? I'm asking just because an int64 seems like an overkill for number of connections, but at the same time I've seen that in other protobuf types we also tend to use int64, e.g:
teleport/lib/events/slice.proto
Line 27 in 3dc51dd
There was a problem hiding this comment.
I'm not sure we have specific guidelines for this. Here I was merely trying to be consistent with the field concerning max regular connections.
Co-authored-by: Edoardo Spadolini <[email protected]>
xacrimon
force-pushed
the
joel/limit-k8s-conn
branch
from
3dc51dd to
616b637
Compare
This PR implements limiting Kubernetes connections the same way as SSH connections can be limited by adding a
max_kubernetes_connectionsconfiguration variable under role options.Fixes #10672