[v9] Backport: helm: Buddy merge for #11368 (Enable persistence in custom mode) #12218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * feat: Standardize persistence * helm: Use deprecated standalone.existingClaimName when specified over newer persistence.existingClaimName * chore: Change pvc comment * feat: Update chart reference * Update docs/pages/kubernetes-access/helm/reference/teleport-cluster.mdx Co-authored-by: Pierre Lebrun <[email protected]>
webvictim
changed the title
|
This is a reasonably big change; the unit tests on the original PR should have covered everything but I'm ever so slightly nervous about backporting it. I don't have the time to go and manually test everything, so if people would rather leave it to come out naturally with Teleport 10, I'm OK with that. I'd just feel bad for the work the original author put in if I didn't raise it. |
zmb3
approved these changes
May 3, 2022
ptgott
approved these changes
May 4, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #11993 to
branch/v9