-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove needlessly complex key generation scheme #12113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
102d8b8
to
afd164d
Compare
Should we leverage teleport/lib/auth/native/native.go Line 128 in bb121d7
This basically always has a keypair ready for you, waiting for you to pull it from a channel. I recall cloud using it in a few places to decrease latency. |
@zmb3 Rewritten the system quite a bit, it now keeps a global key cache which should decrease latency application wide, including tests. |
65edcaf
to
780d1e0
Compare
zmb3
reviewed
Apr 20, 2022
zmb3
reviewed
Apr 20, 2022
zmb3
approved these changes
Apr 20, 2022
hatched
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
application-access
database-access
Database access related issues and PRs
kubernetes
regression
tctl
tctl - Teleport admin tool
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into TEL-Q122-11 which recommends we encrypt keys in the keygen function, I discovered that the suggested encryption is insecure and the entire encryption scheme is deprecated as of Go 1.16. To prevent confusion, I decided to remove the pass parameter from the keygen functions since it isn't actually used anywhere. Upon doing that, I discovered a host of wierd things like remote keygen HTTP APIs and overused indirection that I can't see they serve any purpose. This PR cleans all that up and uses
native.GenerateKeyPair()
for all keypair generation in Teleport.