Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFD: Import EC2 Instance Tags #12049

Merged
merged 8 commits into from
Apr 28, 2022
Merged

RFD: Import EC2 Instance Tags #12049

merged 8 commits into from
Apr 28, 2022

Conversation

atburke
Copy link
Contributor

@atburke atburke commented Apr 18, 2022

Related: #11627.

@atburke atburke added the rfd Request for Discussion label Apr 18, 2022
@github-actions github-actions bot requested review from hatched and smallinsky April 18, 2022 22:43
zmb3
zmb3 approved these changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple. Sounds good to me.

hatched
hatched approved these changes Apr 19, 2022
View reviewed changes
rfd/00xx-ec2-tags.md Outdated Show resolved Hide resolved
r0mant
r0mant requested changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall makes sense, just asking to flesh out a few more details.

rfd/00xx-ec2-tags.md Outdated Show resolved Hide resolved
rfd/00xx-ec2-tags.md Outdated Show resolved Hide resolved
rfd/00xx-ec2-tags.md Outdated Show resolved Hide resolved
rfd/00xx-ec2-tags.md Outdated Show resolved Hide resolved
r0mant
r0mant requested changes Apr 20, 2022
View reviewed changes
rfd/00xx-ec2-tags.md Outdated Show resolved Hide resolved
@atburke
Copy link
Contributor Author

atburke commented Apr 22, 2022

@r0mant Can you take another look at this?

r0mant
r0mant reviewed Apr 27, 2022
View reviewed changes
rfd/00xx-ec2-tags.md Outdated Show resolved Hide resolved
rfd/00xx-ec2-tags.md Outdated Show resolved Hide resolved
rfd/00xx-ec2-tags.md Outdated Show resolved Hide resolved
r0mant
r0mant approved these changes Apr 27, 2022
View reviewed changes
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with the latest round of comments

@atburke atburke enabled auto-merge (squash) April 28, 2022 18:32
@atburke atburke merged commit 412a641 into master Apr 28, 2022
@atburke atburke deleted the atburke/rfd-ec2-tags branch April 28, 2022 18:36
@r0mant r0mant mentioned this pull request May 10, 2022
Merged
@atburke atburke mentioned this pull request May 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0mant r0mant r0mant approved these changes

@hatched hatched hatched approved these changes

@zmb3 zmb3 zmb3 approved these changes

@smallinsky smallinsky Awaiting requested review from smallinsky

Assignees
No one assigned
Labels
rfd Request for Discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atburke @r0mant @hatched @zmb3