Deflake TestCtrlCCapture #11687
Merged
Deflake TestCtrlCCapture #11687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
smallinsky
approved these changes
Apr 4, 2022
espadolini
approved these changes
Apr 4, 2022
zmb3
approved these changes
Apr 4, 2022
xacrimon
added a commit
that referenced
this pull request
Apr 7, 2022
xacrimon
added a commit
that referenced
this pull request
Apr 7, 2022
* Write error and return on failed websocket upgrade (#11606) * Broadcast controls keys if session is moderated (#11661) * Clarify RBAC rule application (#11672) * Use a buffered channel for the terminate notifier (#11687) * Restrict moderated sessions users from accessing V8 kube cluster agents (#11691)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As evidenced in #9492 (comment) this test for
TermManageris flaky. The reasoning for it is in the linked comment.This PR fixes the test flakiness, to do this I considered the following approaches
I investigated 1 but quickly realized that there would be issues. If we remove the default case, two concurrent notifications might attempt to send on the channel, as of the first notification, the channel will close and the second one will result in a panic which is highly undesirable.
A buffered approach seems more promising, this ensures that we can always catch the one termination notification in the test as the write no longer has to be in the background but that any additional ones will be discarded due to the default case which is desirable since the session shall terminate after the first one.