Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new config templates to tbot for databases and identity files #11596

Merged
merged 14 commits into from
May 6, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify comment about client.Key DB certs
timothyb89 committed May 2, 2022
commit 7da161d4792de6b47c0aad04115764fa63257355
6 changes: 3 additions & 3 deletions tool/tbot/config/configtemplate.go
Original file line number Diff line number Diff line change
@@ -247,9 +247,9 @@ func newClientKey(ident *identity.Identity, hostCAs []types.CertAuthority) *clie
TLSCert: ident.TLSCertBytes,
TrustedCA: auth.AuthoritiesToTrustedCerts(hostCAs),

// TODO: configure these? we have a 1:1 mapping of destination
// -> app/db/kube cert so this should be knowable, but are these ever
// used by identityfile?
// Note: these fields are never used or persisted with identity files,
// so we won't bother to set them. (They may need to be reconstituted
// on tsh's end based on cert fields, though.)
KubeTLSCerts: make(map[string][]byte),
DBTLSCerts: make(map[string][]byte),
}