Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport SSH dial deadline to 2.2 #1154

Merged
merged 3 commits into from
Jul 19, 2017
Merged

Backport SSH dial deadline to 2.2 #1154

merged 3 commits into from
Jul 19, 2017

Conversation

r0mant
Copy link
Collaborator

@r0mant r0mant commented Jul 19, 2017

Backport of #1152 to 2.2.

@r0mant r0mant requested review from klizhentas and a-palchikov July 19, 2017 08:22
@gravitational-jenkins
Copy link

Can one of the admins verify this patch?

@r0mant
Copy link
Collaborator Author

r0mant commented Jul 19, 2017

ok to test

1 similar comment
@r0mant
Copy link
Collaborator Author

r0mant commented Jul 19, 2017

ok to test

Copy link
Contributor

@a-palchikov a-palchikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a few typos

CHANGELOG.md Outdated
@@ -74,7 +80,7 @@

Teleport 2.0.5 contains a variety of security fixes. We strongly encourage anyone running Teleport 2.0.0 and above to upgrade to 2.0.5.

The most pressing issues (a phishing attack which can potentially be used to extract plaintext credentials and an attack where an already authenticated user can escalate privileges) can be resolved by upgrading the web proxy. However, however all nodes need to be upgraded to mitigate all vulnerabilities.
The most pressing issues (a phishing attack which can potentially be used to extract plaintext credentials and an attack where an already authenticated user can escalate privileges) can be resolved by upgrading the web proxy. However, however all nodes need to be upgraded to mitigate all vulnerabilities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, however ... one would be enough

CHANGELOG.md Outdated
@@ -74,7 +80,7 @@

Teleport 2.0.5 contains a variety of security fixes. We strongly encourage anyone running Teleport 2.0.0 and above to upgrade to 2.0.5.

The most pressing issues (a phishing attack which can potentially be used to extract plaintext credentials and an attack where an already authenticated user can escalate privileges) can be resolved by upgrading the web proxy. However, however all nodes need to be upgraded to mitigate all vulnerabilities.
The most pressing issues (a phishing attack which can potentially be used to extract plaintext credentials and an attack where an already authenticated user can escalate privileges) can be resolved by upgrading the web proxy. However, however all nodes need to be upgraded to mitigate all vulnerabilities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also lose potentially

@r0mant r0mant merged commit 08a7b49 into branch/2.2 Jul 19, 2017
@r0mant r0mant deleted the roman/2.2/deadline branch July 19, 2017 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants