Fix tsh player issues #11491
Merged
Fix tsh player issues #11491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
force-pushed
the
zmb3/tsh-play-race
branch
3 times, most recently
from
4ff97a1 to
96d6cb4
Compare
zmb3
added
tsh
zmb3
force-pushed
the
zmb3/tsh-play-race
branch
3 times, most recently
from
3707b36 to
6bff75f
Compare
nklaassen
reviewed
Mar 28, 2022
nklaassen
approved these changes
Mar 28, 2022
This commit fixes race conditions in the tsh session player by using a condition variable to detect state changes rather than unsafely polling a variable that is written by a separate goroutine. In addition, fix an off by one error when resuming playback after pausing. The player's position variable has always stored the index of the last succesfully played event, so when we resume playback we should start at position+1 to not re-play the previous event twice. Fixes #11479
zmb3
force-pushed
the
zmb3/tsh-play-race
branch
from
7bffe29 to
79161fd
Compare
ibeckermayer
approved these changes
Mar 29, 2022
zmb3
added a commit
that referenced
this pull request
Mar 29, 2022
This commit fixes race conditions in the tsh session player by using a condition variable to detect state changes rather than unsafely polling a variable that is written by a separate goroutine. In addition, fix an off by one error when resuming playback after pausing. The player's position variable has always stored the index of the last succesfully played event, so when we resume playback we should start at position+1 to not re-play the previous event twice. Fixes #11479
zmb3
added a commit
that referenced
this pull request
Mar 29, 2022
This commit fixes race conditions in the tsh session player by using a condition variable to detect state changes rather than unsafely polling a variable that is written by a separate goroutine. In addition, fix an off by one error when resuming playback after pausing. The player's position variable has always stored the index of the last succesfully played event, so when we resume playback we should start at position+1 to not re-play the previous event twice. Fixes #11479
zmb3
added a commit
that referenced
this pull request
Mar 29, 2022
This commit fixes race conditions in the tsh session player by using a condition variable to detect state changes rather than unsafely polling a variable that is written by a separate goroutine. In addition, fix an off by one error when resuming playback after pausing. The player's position variable has always stored the index of the last succesfully played event, so when we resume playback we should start at position+1 to not re-play the previous event twice. Fixes #11479
zmb3
added a commit
that referenced
this pull request
Mar 31, 2022
This commit fixes race conditions in the tsh session player by using a condition variable to detect state changes rather than unsafely polling a variable that is written by a separate goroutine. In addition, fix an off by one error when resuming playback after pausing. The player's position variable has always stored the index of the last succesfully played event, so when we resume playback we should start at position+1 to not re-play the previous event twice. Fixes #11479
zmb3
added a commit
that referenced
this pull request
Mar 31, 2022
This commit fixes race conditions in the tsh session player by using a condition variable to detect state changes rather than unsafely polling a variable that is written by a separate goroutine. In addition, fix an off by one error when resuming playback after pausing. The player's position variable has always stored the index of the last succesfully played event, so when we resume playback we should start at position+1 to not re-play the previous event twice. Fixes #11479
zmb3
added a commit
that referenced
this pull request
Apr 1, 2022
This commit fixes race conditions in the tsh session player by using a condition variable to detect state changes rather than unsafely polling a variable that is written by a separate goroutine. In addition, fix an off by one error when resuming playback after pausing. The player's position variable has always stored the index of the last succesfully played event, so when we resume playback we should start at position+1 to not re-play the previous event twice. Fixes #11479
zmb3
added a commit
that referenced
this pull request
Apr 1, 2022
This commit fixes race conditions in the tsh session player by using a condition variable to detect state changes rather than unsafely polling a variable that is written by a separate goroutine. In addition, fix an off by one error when resuming playback after pausing. The player's position variable has always stored the index of the last succesfully played event, so when we resume playback we should start at position+1 to not re-play the previous event twice. Fixes #11479
zmb3
added a commit
that referenced
this pull request
Apr 1, 2022
This commit fixes race conditions in the tsh session player by using a condition variable to detect state changes rather than unsafely polling a variable that is written by a separate goroutine. In addition, fix an off by one error when resuming playback after pausing. The player's position variable has always stored the index of the last succesfully played event, so when we resume playback we should start at position+1 to not re-play the previous event twice. Fixes #11479
zmb3
added a commit
that referenced
this pull request
Apr 1, 2022
This commit fixes race conditions in the tsh session player by using a condition variable to detect state changes rather than unsafely polling a variable that is written by a separate goroutine. In addition, fix an off by one error when resuming playback after pausing. The player's position variable has always stored the index of the last succesfully played event, so when we resume playback we should start at position+1 to not re-play the previous event twice. Fixes #11479
zmb3
added a commit
that referenced
this pull request
Apr 1, 2022
This commit fixes race conditions in the tsh session player by using a condition variable to detect state changes rather than unsafely polling a variable that is written by a separate goroutine. In addition, fix an off by one error when resuming playback after pausing. The player's position variable has always stored the index of the last succesfully played event, so when we resume playback we should start at position+1 to not re-play the previous event twice. Fixes #11479
zmb3
added a commit
that referenced
this pull request
Apr 1, 2022
This commit fixes race conditions in the tsh session player by using a condition variable to detect state changes rather than unsafely polling a variable that is written by a separate goroutine. In addition, fix an off by one error when resuming playback after pausing. The player's position variable has always stored the index of the last succesfully played event, so when we resume playback we should start at position+1 to not re-play the previous event twice. Fixes #11479
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes race conditions in the tsh session player by using
a condition variable to detect state changes rather than unsafely
polling a variable that is written by a separate goroutine.
In addition, fix an off by one error when resuming playback
after pausing. The player's position variable has always stored
the index of the last succesfully played event, so when we resume
playback we should start at position+1 to not re-play the previous
event twice.
Fixes #11479