Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8] backport #10336: Add a .tsh/config file and add support for configuring custom http headers #11379

Merged
merged 1 commit into from
Mar 24, 2022
Merged

[v8] backport #10336: Add a .tsh/config file and add support for configuring custom http headers #11379

merged 1 commit into from
Mar 24, 2022

Conversation

lxea
Copy link
Contributor

@lxea lxea commented Mar 23, 2022

backport #10336

ravicious
ravicious reviewed Mar 23, 2022
View reviewed changes
Copy link
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about some changes that were not present in other PRs for this feature.

Makefile Outdated Show resolved Hide resolved
@lxea lxea force-pushed the lxea/tsh-config-v8 branch from fbf44ff to 143e6e9 Compare March 23, 2022 15:21
@lxea lxea enabled auto-merge (rebase) March 24, 2022 11:08
@lxea lxea force-pushed the lxea/tsh-config-v8 branch 2 times, most recently from ae99538 to dbeb08e Compare March 24, 2022 11:37
@lxea lxea force-pushed the lxea/tsh-config-v8 branch from dbeb08e to 57d6551 Compare March 24, 2022 11:53
@lxea lxea merged commit 0d051c5 into branch/v8 Mar 24, 2022
@lxea lxea deleted the lxea/tsh-config-v8 branch March 24, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravicious ravicious ravicious approved these changes

@r0mant r0mant r0mant approved these changes

@timothyb89 timothyb89 Awaiting requested review from timothyb89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lxea @ravicious @r0mant