[v9] UX improvements for tbot (#10833)#11046
Merged
timothyb89 merged 3 commits intobranch/v9from Mar 11, 2022
Merged
Conversation
* UX improvements for tbot A last batch of UX tweaks for 9.0: - rename --renew-interval -> renewal-interval - add `--oneshot` mode to fetch one set of certs and exit (client side only, no server enforcement yet) - add `tbot version` - add unix signal handling: graceful exit on SIGINT, reload on SIGHUP/SIGUSR1 - make auth server an optional config option and check it only when needed (i.e. `tbot start`) * Remove `--auth-server` flag from `tbot init` example * Add `cut` workaround to allow connecting to nodes without DNS * Update product name in tbot CLI help * Add `--format=json` support to `tctl bots add` * Detect OpenSSH version and conditionally remove the RSA deprecation workaround * Fix failing unit test after rename * Update tool/tbot/config/configtemplate_ssh.go Co-authored-by: Zac Bergquist <zmb3@users.noreply.github.com> * Address review feedback * Apply suggestions from code review Co-authored-by: Alan Parra <alan.parra@goteleport.com> * Document IncludeRSAWorkaround and address review comments Co-authored-by: Zac Bergquist <zmb3@users.noreply.github.com> Co-authored-by: Alan Parra <alan.parra@goteleport.com>
r0mant
approved these changes
Mar 10, 2022
zmb3
approved these changes
Mar 10, 2022
russjones
approved these changes
Mar 10, 2022
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10833 for branch/v9
A last batch of UX tweaks for 9.0:
--oneshotmode to fetch one set of certs and exit (clientside only, no server enforcement yet)
tbot versionSIGHUP/SIGUSR1
needed (i.e.
tbot start)Remove
--auth-serverflag fromtbot initexampleAdd
cutworkaround to allow connecting to nodes without DNSUpdate product name in tbot CLI help
Add
--format=jsonsupport totctl bots addDetect OpenSSH version and conditionally remove the RSA deprecation workaround
Fix failing unit test after rename
Update tool/tbot/config/configtemplate_ssh.go
Co-authored-by: Zac Bergquist zmb3@users.noreply.github.com
Address review feedback
Apply suggestions from code review
Co-authored-by: Alan Parra alan.parra@goteleport.com
Co-authored-by: Zac Bergquist zmb3@users.noreply.github.com
Co-authored-by: Alan Parra alan.parra@goteleport.com