[v8] backport #9822 (cert.create event)#10222
Merged
espadolini merged 2 commits intobranch/v8from Feb 14, 2022
Merged
Conversation
* Add the `cert.create` event For now, this is only emitted for user certificate issuance. * Make `cert_type` a string rather than an enum * Match field names and json tags in events.Identity * Change events.Identity.Traits to be a wrappers.LabelValues/wrappers.Traits * Event code shouldn't be under T10xx anymore
zmb3
approved these changes
Feb 8, 2022
russjones
approved these changes
Feb 9, 2022
Contributor
russjones
left a comment
russjones
left a comment
There was a problem hiding this comment.
@espadolini I've approved, but please make sure the Web UI changes are merged first. Otherwise if we cut a release off branch/v8 it could cause the UI to break.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9822.
To be merged after #10303.