Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy can hang due to invalid OIDC connector #2690

Closed
russjones opened this issue Apr 29, 2019 · 0 comments
Closed

Proxy can hang due to invalid OIDC connector #2690

russjones opened this issue Apr 29, 2019 · 0 comments
Labels
Milestone

Comments

@russjones
Copy link
Contributor

If an OIDC connector is created with an invalid issuer_url, the Web UI and proxy locks up for a few minutes and eventually returns.

{"message":"net/http: timeout awaiting response headers"}

During this time, all other connections hang a well. Afterwards the Web UI (and possibly proxy) remains sluggish.

The proxy needs to be restarted to resolve this problem.

@russjones russjones added the bug label Apr 29, 2019
@klizhentas klizhentas added this to the 4.1 "Seattle" milestone May 8, 2019
klizhentas added a commit that referenced this issue Jul 3, 2019
Invalid or inaccessible OIDC connectors were preventing
all other logins to work, as they were grabbing mutex
and making a network call.

Besides, the error was not informative as the user
saw "web headers timeout" error in the browser.

This fix makes sure that:

* Connector errors are isolated to the connector name
and other flows are not blocked
* Error is presented to user in a reasonable way and
provides instructions
* Administrator can see the error in the audit logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants