Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short lived token help message is incorrect #1535

Closed
russjones opened this issue Dec 29, 2017 · 0 comments · Fixed by #1615
Closed

Short lived token help message is incorrect #1535

russjones opened this issue Dec 29, 2017 · 0 comments · Fixed by #1615
Assignees
Labels

Comments

@russjones
Copy link
Contributor

Problem

When creating a short lived token to add a Trusted Cluster, the help message is incorrect.

$ tctl nodes add --roles=trustedcluster --ttl=1h
The invite token: 3225e0acd379ee3658eaf897a8a568ab
Run this on the new node to join the cluster:
> teleport start --roles=trustedcluster --token=3225e0acd379ee3658eaf897a8a568ab --auth-server=10.12.0.6:3025

Please note:
  - This invitation token will expire in 60 minutes
  - 10.12.0.6:3025 must be reachable from the new node, see --advertise-ip server flag

Even though the help message is incorrect, the token is listed and works correctly.

tctl.sh tokens ls
Token                            Role            Expiry Time (UTC)   
-------------------------------- --------------- ------------------- 
3225e0acd379ee3658eaf897a8a568ab Trustedcluster  29 Dec 17 02:22 UTC 

Proposd Solution

Update the help message to explain that the token should be included in a trusted_cluster resource.

@russjones russjones added the ux label Dec 29, 2017
@klizhentas klizhentas added this to the 2.5.0 milestone Jan 4, 2018
@klizhentas klizhentas added the P2 label Jan 6, 2018
klizhentas added a commit that referenced this issue Jan 18, 2018
fixes #1546, fixes #1535

This commit fixes error message in case if token
is generated for trusted cluster and allows
admins to provide custom tokens:

tctl nodes add --roles=node --token=custom --ttl=100h
hatched pushed a commit that referenced this issue Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants