Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct terminal type handling #1402

Closed
russjones opened this issue Oct 14, 2017 · 1 comment
Closed

Correct terminal type handling #1402

russjones opened this issue Oct 14, 2017 · 1 comment
Assignees

Comments

@russjones
Copy link
Contributor

Problem

Teleport tries to read in the terminal type from environment variables on the server, this should be done on the client and the server should request the terminal type passed in pty-req.

Proposed Solution

On the server side, when teleport processing pty-req extract the terminal type and store it in the context and use that when requesting a terminal.

On the client side when tsh is sending requests, it should extract TERM from the environment of the user and pack this into a pty-req. If TERM is not set, then use xterm-256color (not sure about this last bit yet).

@russjones
Copy link
Contributor Author

Fixed in Teleport 2.4.0.

hatched pushed a commit that referenced this issue Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants