This repository was archived by the owner on Jun 4, 2024. It is now read-only.
Conversation
Update Teleport version to 14.0.0 from 13.8.8. The former has now been released and is available. Update the Go version to 1.21.1, as used by Teleport 14. Fix a couple of tests that used `lib/client.Client.CreateAccessRequest()` to use `CreateAccessRequestV2()` as that supersedes the former. The fix is as per gravitational/teleport#31760. Co-authored-by: Cam Hutchison <camh@goteleport.com>
Update the go.mod file to use Teleport 14 from the tag not the branch by running: make update-teleport-dep-version VERSION=14.0.0 The codeql workflow still seems to use an older version of Go which fails to parse the new `toolchain` directive in `go.mod`, so add a "Set up Go" step the same as the Teleport repo to ensure the latest version is installed for the workflow.
camscale
force-pushed
the
camh/prep-t14
branch
from
199177c to
bdf254c
Compare
Use 2.1.0 as this is the current latest of gravitational/protoc-gen-terraform, and the instructions say to use the latest.
Specify `RoleV6.Spec.Allow.KubernetesResources.Verbs` as a computed
field and re-generate the terraform provider. This is needed as the
verbs field has a default value of `[ "*" ]`, which causes the error:
role_test.go:244: Step 7/8 error: Error running apply: exit status 1
Error: Provider produced inconsistent result after apply
When applying changes to teleport_role.upgrade, provider
"provider[\"registry.terraform.io/hashicorp/teleport\"]" produced an
unexpected new value: .spec.allow.kubernetes_resources[0].verbs: was null,
but now cty.ListVal([]cty.Value{cty.StringVal("*")}).
This is a bug in the provider, which should be reported in the provider's own
issue tracker.
Ideally this would not be computed but would have a default specified
instead, but it does not look like we can do that with the current
generator.
camscale
requested review from
Joerger,
fheinecke,
klizhentas,
r0mant,
russjones,
tcsc and
zmb3
as code owners
marcoandredinis
approved these changes
Sep 21, 2023
Contributor
Author
|
Closed in favour of Marco's one (#920) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Teleport version to 14.0.0 from 13.8.8. The former has now been
released and is available.
Update the Go version to 1.21.1, as used by Teleport 14.
Fix a couple of tests that used
lib/client.Client.CreateAccessRequest()to use
CreateAccessRequestV2()as that supersedes the former. The fixis as per gravitational/teleport#31760.
Update the version of protoc-gen-terraform required to 2.1.0 from 2.0.2
as that is what the HEAD of the repository now is.
Add
RoleV6...KubernetesResources.Verbsas a computed field as ithas a default of
[ "*" ]in Teleport 14 and we get a test error without it.