Pin package versions to match Teleport v12#773
Conversation
| golang.org/x/net v0.7.0 | ||
| golang.org/x/sync v0.1.0 | ||
| google.golang.org/grpc v1.53.0 | ||
| google.golang.org/grpc v1.52.3 |
There was a problem hiding this comment.
grpc downgraded because it was pulling a newer genproto version. Rest of the changes (other than the "pinned" block) were made by go mod tidy.
marcoandredinis
left a comment
There was a problem hiding this comment.
Maybe we should re-use the teleport repo model here
master is the next release and have a branch/v12 🤔
I would rather have this the other way around 🤔 I guess we are a bit late now |
One good thing is, technically the dependency is not circular, as Importing |
|
Yeah, you've got a point there: I guess we would need to move I'm not entirely sure of the Well, that's not a huge deal. Just a change of my personal perception of what depends on what. |
@justinas @marcoandredinis This might be a good thing, as we're working on OpsGenie plugin that is the first plugin that's going to live in Teleport repo and be a part of |
|
@r0mant could I get your approval on this PR? |
We are now importing
teleport-pluginsin theteleportrepo. However, teleport's v12 branch is holding back packages related to Firestore due to incompatibilities (this has since been solved in master by gravitational/teleport#21190).To avoid bumping these packages in teleport, this PR pins the packages in teleport-plugins as well.