Reapply: Fix an issue status type (+) is not read/write properly #37
Merged
Reapply: Fix an issue status type (+) is not read/write properly #37
Conversation
greedy52
force-pushed
the
STeve/reapply_status_fix
branch
from
35f9605 to
6d50ab7
Compare
jentfoo
reviewed
Mar 7, 2023
|
|
||
| switch line[0] { | ||
| case RespStatus: | ||
| if r.opt.useStatusStringType { |
There was a problem hiding this comment.
This fixes the tests, but do we worry it might introduce an unexpected condition when enabled?
Author
There was a problem hiding this comment.
do we worry it might introduce an unexpected condition when enabled?
No, i don't think so. This change just means when Teleport is using the Reader explicitly/directly, we always get the StatusString type, which is what the Teleport db engine wants. And when Reader is used internally by the go-redis driver itself, it's a string like the old day.
jentfoo
approved these changes
Mar 7, 2023
jentfoo
left a comment
jentfoo
left a comment
There was a problem hiding this comment.
Looks good, particularly considering we will need to test the 9.0.2 update in general anyways
smallinsky
approved these changes
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-picked c2209e9
added a
ReaderOptfor choosingStatusStringvsstring, see 6d50ab7