Skip to content

feat!: Require devices to be explicitly closed #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codingllama merged 7 commits into from
Jan 23, 2024
Merged

feat!: Require devices to be explicitly closed #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
443c5fa
Require devices to be explicitly closed
codingllama Jan 8, 2024
b57f088
Drop hardcoded PIN from tests
codingllama Jan 8, 2024
2a177d5
Fix a few Examples, forbid others
codingllama Jan 8, 2024
728a6b7
Fix "device nil" error message
codingllama Jan 12, 2024
b14fe43
Cancel on failed fido_dev_get_assert or fido_dev_make_cred
codingllama Jan 15, 2024
b267d1e
Add the SetTimeout function
codingllama Jan 15, 2024
0c5f41f
Delete dangerous/destructive example tests
codingllama Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
219 changes: 18 additions & 201 deletions examples_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ func ExampleDeviceLocations() {
if err != nil {
log.Fatal(err)
}
defer device.Close()

hidInfo, err := device.CTAPHIDInfo()
if err != nil {
Expand Down Expand Up @@ -65,10 +66,11 @@ func ExampleDevice_MakeCredential() {
if err != nil {
log.Fatal(err)
}
defer device.Close()

cdh := libfido2.RandBytes(32)
userID := libfido2.RandBytes(32)
pin := "12345"
pin := getPIN()

attest, err := device.MakeCredential(
cdh,
Expand Down Expand Up @@ -105,8 +107,7 @@ func ExampleDevice_Assertion() {
return
}

// Note: change as appropriate.
const pin = "12345"
pin := getPIN()

locs, err := libfido2.DeviceLocations()
if err != nil {
Expand All @@ -123,6 +124,7 @@ func ExampleDevice_Assertion() {
if err != nil {
log.Fatal(err)
}
defer device.Close()

cdh := libfido2.RandBytes(32)
userID := libfido2.RandBytes(32)
Expand Down Expand Up @@ -206,8 +208,9 @@ func ExampleDevice_Credentials() {
if err != nil {
log.Fatal(err)
}
defer device.Close()

pin := "12345"
pin := getPIN()

info, err := device.CredentialsInfo(pin)
if err != nil {
Expand Down Expand Up @@ -237,74 +240,6 @@ func ExampleDevice_Credentials() {
//
}

func Dont_ExampleDevice_Reset() {
if os.Getenv("FIDO2_EXAMPLES") != "1" {
return
}
libfido2.SetLogger(libfido2.NewLogger(libfido2.DebugLevel))

if os.Getenv("FIDO2_EXAMPLES_RESET") != "1" {
log.Println("only runs if FIDO2_EXAMPLES_RESET=1")
return
}

locs, err := libfido2.DeviceLocations()
if err != nil {
log.Fatal(err)
}
if len(locs) == 0 {
log.Println("No devices")
return
}

log.Printf("Using device: %+v\n", locs[0])
path := locs[0].Path
device, err := libfido2.NewDevice(path)
if err != nil {
log.Fatal(err)
}

log.Printf("Resetting: %+v\n", locs[0])
if err := device.Reset(); err != nil {
log.Fatal(err)
}

// Output:
//

}

func Dont_ExampleDevice_SetPIN() {
if os.Getenv("FIDO2_EXAMPLES_SET_PIN") != "1" {
return
}
libfido2.SetLogger(libfido2.NewLogger(libfido2.DebugLevel))

locs, err := libfido2.DeviceLocations()
if err != nil {
log.Fatal(err)
}
if len(locs) == 0 {
log.Println("No devices")
return
}

log.Printf("Using device: %+v\n", locs[0])
path := locs[0].Path
device, err := libfido2.NewDevice(path)
if err != nil {
log.Fatal(err)
}

pin := "12345"
if err := device.SetPIN(pin, ""); err != nil {
log.Fatal(err)
}

// Output:
//
}

func ExampleDevice_MakeCredential_hmacSecret() {
if os.Getenv("FIDO2_EXAMPLES") != "1" {
return
Expand All @@ -324,10 +259,11 @@ func ExampleDevice_MakeCredential_hmacSecret() {
if err != nil {
log.Fatal(err)
}
defer device.Close()

cdh := bytes.Repeat([]byte{0x01}, 32)
rpID := "keys.pub"
pin := "12345"
pin := getPIN()

attest, err := device.MakeCredential(
cdh,
Expand All @@ -353,6 +289,9 @@ func ExampleDevice_MakeCredential_hmacSecret() {
}

log.Printf("Credential ID: %s\n", hex.EncodeToString(attest.CredentialID))

// Output:
//
Comment thread
codingllama marked this conversation as resolved.
}

type testVector struct {
Expand All @@ -378,12 +317,13 @@ func ExampleDevice_Assertion_hmacSecret() {
if err != nil {
log.Fatal(err)
}
defer device.Close()

name := locs[0].Product + "/" + locs[0].Manufacturer

cdh := bytes.Repeat([]byte{0x01}, 32)
rpID := "keys.pub"
pin := "12345"
pin := getPIN()

testVectors := map[string]testVector{
"SoloKey 4.0/SoloKeys": testVector{
Expand Down Expand Up @@ -430,52 +370,6 @@ func ExampleDevice_Assertion_hmacSecret() {
if testVector.Secret != hex.EncodeToString(assertion.HMACSecret) {
log.Fatalf("Expected %s", testVector.Secret)
}
}

func ExampleDevice_DeleteCredential() {
if os.Getenv("FIDO2_EXAMPLES") != "1" {
return
}
locs, err := libfido2.DeviceLocations()
if err != nil {
log.Fatal(err)
}
if len(locs) == 0 {
log.Fatal("No devices")
return
}

log.Printf("Using device: %+v\n", locs[0])
path := locs[0].Path
device, err := libfido2.NewDevice(path)
if err != nil {
log.Fatal(err)
}

pin := "12345"

info, err := device.CredentialsInfo(pin)
if err != nil {
log.Fatal(err)
}
log.Printf("Info: %+v\n", info)

rps, err := device.RelyingParties(pin)
if err != nil {
log.Fatal(err)
}
for _, rp := range rps {
creds, err := device.Credentials(rp.ID, pin)
if err != nil {
log.Fatal(err)
}
for _, cred := range creds {
log.Printf("Deleting: %s\n", hex.EncodeToString(cred.ID))
if err := device.DeleteCredential(cred.ID, pin); err != nil {
log.Fatal(err)
}
}
}

// Output:
//
Expand All @@ -500,8 +394,9 @@ func ExampleDevice_BioEnrollment() {
if err != nil {
log.Fatal(err)
}
defer device.Close()

pin := "12345"
pin := getPIN()

err = device.BioEnroll(pin)
if err != nil {
Expand Down Expand Up @@ -531,8 +426,9 @@ func ExampleDevice_BioList() {
if err != nil {
log.Fatal(err)
}
defer device.Close()

pin := "12345"
pin := getPIN()

templates, err := device.BioList(pin)
if err != nil {
Expand All @@ -544,82 +440,3 @@ func ExampleDevice_BioList() {
// Output:
//
}

func ExampleDevice_BioDelete() {
if os.Getenv("FIDO2_EXAMPLES") != "1" {
return
}
locs, err := libfido2.DeviceLocations()
if err != nil {
log.Fatal(err)
}
if len(locs) == 0 {
log.Fatal("No devices")
return
}

log.Printf("Using device: %+v\n", locs[0])
path := locs[0].Path
device, err := libfido2.NewDevice(path)
if err != nil {
log.Fatal(err)
}

pin := "12345"

templates, err := device.BioList(pin)
if err != nil {
log.Fatal(err)
}

for _, template := range templates {
err := device.BioDelete(pin, template.ID)
if err != nil {
log.Fatal(err)
}
}

// Output:
//
}

func ExampleDevice_BioSetTemplateName() {
if os.Getenv("FIDO2_EXAMPLES") != "1" {
return
}
locs, err := libfido2.DeviceLocations()
if err != nil {
log.Fatal(err)
}
if len(locs) == 0 {
log.Fatal("No devices")
return
}

log.Printf("Using device: %+v\n", locs[0])
path := locs[0].Path
device, err := libfido2.NewDevice(path)
if err != nil {
log.Fatal(err)
}

pin := "12345"

templates, err := device.BioList(pin)
if err != nil {
log.Fatal(err)
}

if len(templates) == 0 {
log.Fatal("no bio template")
return
}

template := templates[0]
newName := "newName"

device.BioSetTemplateName(pin, template.ID, newName)

// Output:
//
}
Loading