beam-init: add version endpoint - #132
Open
rcanderson23 wants to merge 1 commit into
Open
Conversation
rcanderson23
force-pushed
the
carson/beam-init-version
branch
5 times, most recently
from
August 11, 2026 18:35
bbe0df1 to
e97f0c5
Compare
rcanderson23
marked this pull request as ready for review
August 11, 2026 18:36
rcanderson23
requested review from
bjorn3,
boxofrad,
folkertdev and
sclevine
and removed request for
bjorn3
August 11, 2026 18:37
Adds version endpoint to beam-init as well as command to beamctl.
rcanderson23
force-pushed
the
carson/beam-init-version
branch
from
August 11, 2026 18:40
e97f0c5 to
62dfc8d
Compare
bjorn3
reviewed
Aug 12, 2026
| pub(crate) const GIT_SHA: &str = match option_env!("GIT_SHA") { | ||
| Some(sha) => sha, | ||
| None => "unknown", | ||
| }; |
Collaborator
There was a problem hiding this comment.
Maybe this could be put in beam-init/src/lib.rs to share it between beam-init and beamctl?
Contributor
Author
There was a problem hiding this comment.
Yeah, I originally did that but moved to individual bins since it required pub visibility
Collaborator
There was a problem hiding this comment.
I don't think it would be a problem to make these pub in the beam-init library.
bjorn3
approved these changes
Aug 12, 2026
bjorn3
left a comment
bjorn3
left a comment
Collaborator
There was a problem hiding this comment.
With or without the consts moved to lib.rs.
boxofrad
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds version endpoint to beam-init as well as command to beamctl.