-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyproject for maturin 1.8.0 #45
Conversation
small up, I am waiting for this. Can this being merged? Thanks a lot |
@daxpryce @nicaurvi , could you please take a look? |
nevermind all of that, you haven't had to do anything in this repo. I'll try to take a look tomorrow. Sorry this hasn't been kept up to date with maturin folks, I haven't had any time to work on this in years 😅 |
@daxpryce Thank you so much for your help. Would it be possible to get an estimated timeline for when this might be resolved? If it takes longer than anticipated, we may need to explore a workaround. Just to clarify, we understand that you owe us nothing, and we truly appreciate your prompt response and kindness. |
Also, I'd be happy to contribute, if you could offer the necessary guidance. |
This is likely such an easy fix - indeed we have a great example of how it could work submitted by @dylanwhawk - I just need to read through exactly what is going on, why it is happening, and what the proper way to fix it is (like, it very likely could be their exact method, but I want to make sure I'm not raising any weird issues where if version is dynamic [something] malicious could be slipstreamed into it or something. it's exceedingly unlikely, but I still don't want to be hasty :) ) timeline: I would expect tomorrow or Wednesday (pacific timezone). If it's taking longer I'll be sure to let everyone know :) |
No worries, I'm just glad someone is finding some use for it! If I had my way I'd revisit the whole thing again, knowing what I know now about... so many things 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this @dylanwhawk !
Of course! Happy that this got resolved for everyone waiting for it. |
Many thanks to all of you!! |
Because it pained me to leave us so many versions behind on so many things in this, I took the day and ... kinda got target fixation and tried to do way too much stuff at once. But anyway, there's a PR out now as a prep for 1.2.2 - #46 . If any of you fine folks wouldn't mind doing a PR of all my changes - in specific noting that we are dropping support for python 3.6 an 3.7 (now that they're not available in the most up-to-date pyo3) . I would not mind community feedback on this well before I make the change, especially since it's somehow still a patch release. |
I didn't merge the dang thing after I approved it. I am an absolute genius. |
https://pypi.org/project/graspologic-native/1.2.2.dev2025010812680358310/ was released as a prerelease today. @darthtrevino, if you could test this with graphrag to make sure it works for everyone here that would be great. Once I know I'm not breaking things for everyone I'll create the final 1.2.2 release. The unit testing scenario around this project is absolutely dire |
Fixes #44