Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start building as a shared library on Windows (DLL) #67

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Start building as a shared library on Windows (DLL) #67

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1678e6f
Start building as a static library on Windows with python2 and winfle…
wravery Jul 25, 2018
69a9262
Switch to a SHARED library on Windows
wravery Jul 26, 2018
7bcd1f3
Add the import .lib and the .pdb symbols to the installed files on Wi…
wravery Jul 26, 2018
c06cad6
Put back the UNIX -std=gnu++11 flag
wravery Jul 26, 2018
e860954
Cleanup some duplicate defines and move the test block out of if(UNIX)
wravery Sep 6, 2018
8e1e0c7
Get the unit tests building and passing on Windows
wravery Sep 7, 2018
d8871fb
Merge branch 'master' into master
wravery Sep 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 37 additions & 20 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,17 @@ SET(CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake" "${CMAKE_MODULE_PATH}")

INCLUDE(version)

SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=gnu++11")

FIND_PACKAGE(PythonInterp 2 REQUIRED)
IF (NOT PYTHON_VERSION_MAJOR EQUAL 2)
MESSAGE(FATAL_ERROR "Python 2 is required.")
ENDIF()

IF(UNIX)
wravery marked this conversation as resolved.
Show resolved Hide resolved
SET(FLEX_COMPILE_FLAGS "--header-file=lexer.h")
ELSEIF(WIN32)
SET(FLEX_COMPILE_FLAGS "--header-file=lexer.h --wincompat")
ENDIF()

FIND_PROGRAM(CTYPESGEN_FOUND ctypesgen.py)

FIND_PACKAGE(BISON 3)
Expand All @@ -21,7 +25,7 @@ IF (BISON_FOUND)
ENDIF()

IF(FLEX_FOUND)
FLEX_TARGET(GraphQLScanner lexer.lpp ${CMAKE_CURRENT_SOURCE_DIR}/lexer.cpp COMPILE_FLAGS "--header-file=lexer.h")
FLEX_TARGET(GraphQLScanner lexer.lpp ${CMAKE_CURRENT_SOURCE_DIR}/lexer.cpp COMPILE_FLAGS ${FLEX_COMPILE_FLAGS})
IF (BISON_FOUND)
ADD_FLEX_BISON_DEPENDENCY(GraphQLScanner graphqlparser)
ENDIF()
Expand All @@ -31,7 +35,7 @@ FILE(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/c)
INCLUDE_DIRECTORIES(${CMAKE_CURRENT_SOURCE_DIR})
INCLUDE_DIRECTORIES(${CMAKE_CURRENT_BINARY_DIR})

ADD_LIBRARY(graphqlparser SHARED
SET(GRAPHQLPARSER_SOURCES
JsonVisitor.cpp
${CMAKE_CURRENT_BINARY_DIR}/Ast.h
${CMAKE_CURRENT_BINARY_DIR}/Ast.cpp
Expand All @@ -52,10 +56,19 @@ ADD_LIBRARY(graphqlparser SHARED
lexer.h
GraphQLParser.cpp)

# Enable this and remove CMAKE_CXX_FLAGS fiddle above when we are able
# to upgrade to CMake 2.8.12. Blocker seems to be Travis CI being on
# Ubuntu Precise; Trusty has 2.8.12.
# TARGET_COMPILE_OPTIONS(graphqlparser PUBLIC -std=gnu++11)
IF(UNIX)
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=gnu++11")

ADD_LIBRARY(graphqlparser SHARED ${GRAPHQLPARSER_SOURCES})

# Enable this and remove CMAKE_CXX_FLAGS fiddle above when we are able
# to upgrade to CMake 2.8.12. Blocker seems to be Travis CI being on
# Ubuntu Precise; Trusty has 2.8.12.
# TARGET_COMPILE_OPTIONS(graphqlparser PUBLIC -std=gnu++11)
ELSEIF(WIN32)
ADD_LIBRARY(graphqlparser STATIC ${GRAPHQLPARSER_SOURCES})
wravery marked this conversation as resolved.
Show resolved Hide resolved
ENDIF()


ADD_EXECUTABLE(dump_json_ast dump_json_ast.cpp)
TARGET_LINK_LIBRARIES(dump_json_ast graphqlparser)
Expand Down Expand Up @@ -104,10 +117,11 @@ INSTALL(FILES
stack.hh
syntaxdefs.h
DESTINATION include/graphqlparser)
INSTALL(TARGETS graphqlparser
LIBRARY DESTINATION lib)

if (UNIX)
INSTALL(TARGETS graphqlparser
LIBRARY DESTINATION lib)

# generate pkgconfig file
include(FindPkgConfig QUIET)
if(PKG_CONFIG_FOUND)
Expand All @@ -116,16 +130,19 @@ if (UNIX)
install(FILES "${CMAKE_CURRENT_BINARY_DIR}/libgraphqlparser.pc"
DESTINATION "${CMAKE_INSTALL_PREFIX}/lib/pkgconfig")
endif()
endif()

IF (test)
ADD_SUBDIRECTORY(test)
IF (test)
ADD_SUBDIRECTORY(test)

if(UNIX)
# setup valgrind
ADD_CUSTOM_TARGET(memcheck
valgrind --leak-check=full --suppressions=./test/valgrind.supp --dsymutil=yes --error-exitcode=1 ./test/runTests >/dev/null
)
endif()
if(UNIX)
wravery marked this conversation as resolved.
Show resolved Hide resolved
# setup valgrind
ADD_CUSTOM_TARGET(memcheck
valgrind --leak-check=full --suppressions=./test/valgrind.supp --dsymutil=yes --error-exitcode=1 ./test/runTests >/dev/null
)
endif()

ENDIF()
ENDIF()
elseif(WIN32)
INSTALL(TARGETS graphqlparser
ARCHIVE DESTINATION lib)
endif()