Windows Support #35
Windows Support #35
Conversation
|
Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email [email protected] with your details so we can update your status. |
|
I think something is wrong with the CLA. I used to work at Facebook, so my CLA should definitely be on file. This is what I see when I go to the CLA web form:
|
We revoke employee CLAs when you become an ex-employee, as you have changed from contributing on behalf of your employer to contributing individually |
| FILE(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/c) | ||
| INCLUDE_DIRECTORIES(${CMAKE_CURRENT_SOURCE_DIR}) | ||
| INCLUDE_DIRECTORIES(${CMAKE_CURRENT_BINARY_DIR}) | ||
|
|
||
| ADD_LIBRARY(graphqlparser SHARED | ||
| ADD_LIBRARY(graphqlparser |
There was a problem hiding this comment.
Is it really necessary to build as a different flavor of library for Windows? I think this might break the Python/Go examples.
|
Hey, I switched gears to using https://github.com/graphql-go/graphql. This is a cool project, so I'd love to come back to using it one of these days, but I'm going to close this for now in interest of keeping the PR list clean and if I have a chance to invest time in doing this right, I'll re-open. |
* Referencing graphql#35
I had to make a few changes to
CMakeLists.txtin order to get libgraphqlparser to build and install on Windows 10. I haven't explicitly tested this on *nix, but the travis tests are passing, so that's promising.