Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec edits for @defer/@stream #742
Spec edits for @defer/@stream #742
Changes from all commits
42bd98a
583acb6
a4bbad6
b4fb65c
3257f19
3cce3fa
f81d745
b0cae7f
9449853
c812890
c1fefe4
6dd9b79
ebfefb6
30674c8
101516b
80ff450
b73af22
f634192
7eafac8
83e058d
5aa915b
d7fe43a
379f10c
1ffad84
21dd0bc
3a569b6
a596ead
4543a47
5a093cd
8fa426e
fcc6393
aa22c5f
089d06c
a154bda
67689c5
9230085
4bf09d0
1499e64
722de48
c4bdfaf
d84dd0b
2248f35
2fb409c
66c3f7b
9287b62
e0c0ad9
99baf54
4931f7a
da96e98
aff1113
fb3e05c
039e4eb
777c21b
7626800
d16a432
979e581
1207121
6545a55
4c2e3f9
e4ee3eb
22de5de
c630301
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if they have just different initialCount, shouldn't it be considered 'the same' case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was what was decided based on feedback from Facebook's implementation: graphql/graphql-js#2319 (comment)
If multiple streams on the same field are needed, they can be aliased. Again, if this blocks certain use cases I think it can be explored in a follow up proposal.