Be explicit how to handle unknown request information #1151
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
benjie
added
the
✏️ Editorial
|
looks right - I'll tweak wording and then merge |
| operationName, variableValues, initialValue)} produces the response, to be | ||
| formatted according to the Response section below. | ||
|
|
||
| A GraphQL service must ignore unrecognized information in a request. This allows |
There was a problem hiding this comment.
This seems a little broad; arguably something inside the document (an unknown directive, a new syntactic symbol, fragment arguments) is in the request and could be unrecognized, and those should result in validation/parse errors rather than being ignored. Maybe we can use “additional” instead, such as “must ignore any additional unrecognised information” - that implies it’s outside of what’s already specified here?
There was a problem hiding this comment.
Makes sense to me 👍 . I know @leebyron wanted to make some wording changes, I'll defer to his decision.
Co-authored-by: Benjie <[email protected]>
|
This was taken care of in #976, closing. |
8 participants
As we are discussing adding a new request parameter for disabling error propagation, we'll need this. This should probably have been added 5 years ago but now is better than later. I think this is what most implementations are doing anyway.