Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript declaration files #279

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Conversation

danielrearden
Copy link
Collaborator

The DefinitelyTyped definitions are pretty misaligned with the Flow definitions. A good example is ConnectionConfig.nodeType which is typed as GraphQLObjectType in Flow (here) but is effectively typed as GraphQLOutputType in DT (here). I'll do a separate PR to sync these with Flow so that there's a clear record of what changed. The only thing I did sync was the comments to reduce the diff for the next PR.

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #279 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #279   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          19       19           
  Lines         595      595           
  Branches       38       38           
=======================================
  Hits          592      592           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61883e1...e5be00b. Read the comment docs.

@IvanGoncharov IvanGoncharov merged commit 9cb03e3 into graphql:master Jul 8, 2020
@IvanGoncharov IvanGoncharov added the PR: feature 🚀 requires increase of "minor" version number label Jul 8, 2020
@IvanGoncharov IvanGoncharov mentioned this pull request Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature 🚀 requires increase of "minor" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants