Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary async code #269

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Conversation

IvanGoncharov
Copy link
Member

No description provided.

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jun 25, 2020
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #269 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
- Coverage   99.51%   99.49%   -0.02%     
==========================================
  Files          19       19              
  Lines         618      598      -20     
  Branches       36       38       +2     
==========================================
- Hits          615      595      -20     
  Misses          3        3              
Impacted Files Coverage Δ
src/__tests__/starWarsConnectionTests.js 100.00% <100.00%> (ø)
src/__tests__/starWarsMutationTests.js 100.00% <100.00%> (ø)
src/__tests__/starWarsObjectIdentificationTests.js 100.00% <100.00%> (ø)
src/connection/__tests__/connection.js 100.00% <100.00%> (ø)
src/mutation/__tests__/mutation.js 96.49% <100.00%> (ø)
src/mutation/mutation.js 100.00% <100.00%> (ø)
src/node/__tests__/global.js 100.00% <100.00%> (ø)
src/node/__tests__/node.js 100.00% <100.00%> (ø)
src/node/node.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0595d8b...f5ebf9a. Read the comment docs.

@IvanGoncharov IvanGoncharov merged commit 449c0d5 into graphql:master Jun 25, 2020
@IvanGoncharov IvanGoncharov deleted the pr_branch branch June 25, 2020 14:36
IvanGoncharov added a commit to IvanGoncharov/graphql-relay-js that referenced this pull request Jun 25, 2020
IvanGoncharov added a commit to IvanGoncharov/graphql-relay-js that referenced this pull request Jun 25, 2020
IvanGoncharov added a commit that referenced this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant