Schema polling autoupdate #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, save button saves disabled comments
Fix for additional line-breaks after each item
Schema will now default to true for commentsDisabled and commentDescription properties
* Schema only updates in state if it has changed
Fix for additional line-breaks after each item
Schema will now default to true for commentsDisabled and commentDescription properties
* Schema only updates in state if it has changed
…/gql-playground into schema-polling-autoupdate
Closed
|
Thanks for a great job on this feature! I can't wait to start using it. 🚀 |
RenovZ
pushed a commit
to RenovZ/graphql-playground
that referenced
this pull request
Mar 25, 2022
* Merged from sdl-tabs https://github.com/Novvum/graphql-playground.git * Added and integrated setting's key for 'schema.disableComments' * Merged changes from disableComments branch * Fixes and style changes matching @kuldar's design specs. Details on graphql#897 comments * Still not able to cmd+save settings. Might be a deeper issue. However, save button saves disabled comments * Added tabWidth prop to SideTab.tsx to provide specific widths for different tabs. * Fix for Tab Spacing in collapsed state Fix for additional line-breaks after each item * ugly version is done * moved icons to the left * making polling global * Updates for using 'esc' on keydown to close tabs * added polling config * Updated createSDL.tsx Schema will now default to true for commentsDisabled and commentDescription properties * Fixed Electron * Hiding reload icon if polling is enabled * * Updated schema polling icon * Schema only updates in state if it has changed * code cleanup * Merged from sdl-tabs https://github.com/Novvum/graphql-playground.git * Added and integrated setting's key for 'schema.disableComments' * Merged changes from disableComments branch * Fixes and style changes matching @kuldar's design specs. Details on graphql#897 comments * Added tabWidth prop to SideTab.tsx to provide specific widths for different tabs. * Fix for Tab Spacing in collapsed state Fix for additional line-breaks after each item * ugly version is done * moved icons to the left * making polling global * Updates for using 'esc' on keydown to close tabs * added polling config * Updated createSDL.tsx Schema will now default to true for commentsDisabled and commentDescription properties * Fixed Electron * Hiding reload icon if polling is enabled * * Updated schema polling icon * Schema only updates in state if it has changed * code cleanup * removed questiomark * removed duplicate funciton * updated files from upstream * yarn.lock from upstream * using printSchema instead of JSON.stringify to compare schemas * reusing reload icon * "Refresh to see changes" feature in SCHEMA tab * disabled animation for polling * changed polling icon and moved back to right side. * automatically updating schema view without scrolling when schema updates * moved reload icon back to the left * automatically updating schema view without scrolling when schema updates * more accurate schema diff checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative option to #922.
This pr will automatically update the schema tab in place without scrolling to top and will NOT show the "Refresh to see changes" button when the schema changes.