Fixing interfaces and unions in docs #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huv1k
commented
Feb 12, 2018
| const implementationsOffset = | ||
| obj.fields.length + obj.interfaces.length + obj.args.length | ||
|
|
||
| const typeInstance = |
There was a problem hiding this comment.
I am not happy with this style of coding, but was trying to follow lint rules. I can change it to something like this:
if (type instanceof GraphQLInterfaceType) {
typeInstance = 'interface'
} else if (type instanceof GraphQLUnionType) {
typeInstance = 'union'
} else if (type instanceof GraphQLEnumType) {
typeInstance = 'enum'
} else {
typeInstance = 'type'
}What looks better in my eyes
There was a problem hiding this comment.
Yes, that look definitely better! You can also identify that linting rule and ignore it in the tslint config.
I already had a lot of cases where this rule forced you to do this ugly ternary stuff.
RenovZ
pushed a commit
to RenovZ/graphql-playground
that referenced
this pull request
Mar 25, 2022
* Fixing interfaces and unions in docs * Change linting and conditions * Prettier not working correctly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #322 #171.
Changes proposed in this pull request:
Added link to unions, renamed details for enums etc and added interfaces