-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(incremental): merge deferred fragments at the same level #3820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
force-pushed
the
try-merge
branch
6 times, most recently
from
January 10, 2023 15:15
f1c30e9
to
4080c48
Compare
yaacovCR
changed the title
try aggressive defer merging
feat(incremental): merge deferred fragments at the same level
Jan 10, 2023
yaacovCR
force-pushed
the
try-merge
branch
5 times, most recently
from
January 12, 2023 12:09
3da1cf0
to
f15c6aa
Compare
robrichard
reviewed
Jan 13, 2023
yaacovCR
force-pushed
the
try-merge
branch
8 times, most recently
from
January 14, 2023 22:03
bd40bac
to
eea85cc
Compare
this is ready for re-review, same basic approach, but:
|
yaacovCR
force-pushed
the
try-merge
branch
2 times, most recently
from
January 15, 2023 10:00
db9dc35
to
d998e79
Compare
yaacovCR
force-pushed
the
try-merge
branch
2 times, most recently
from
January 17, 2023 09:50
856a95c
to
e7512c0
Compare
closing this in favor of #3862 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #3827
This PR attempts to implement the defer merging portion of the latest proposal:
Links:
graphql/defer-stream-wg#64
graphql/defer-stream-wg#52 (comment)
Corresponding spec edits are at: robrichard/graphql-spec#10