fix: handle more unhandled promise rejections #3761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yaacovCR
force-pushed
the
fix-sync-async
branch
from
bd5fc30
to
86106a7
Compare
yaacovCR
force-pushed
the
fix-sync-async
branch
from
86106a7
to
bac2183
Compare
|
Rebased on main -- and also simplified! |
following graphql#3706 fix for field execution
yaacovCR
force-pushed
the
fix-sync-async
branch
from
bac2183
to
4ed99d5
Compare
saihaj
approved these changes
Jan 13, 2023
|
Any chance of a v16 release with this fix? It stung us today and it was really hard to figure out what was going on. I think @yaacovCR hadn't already debugged and opened this PR we would still be scratching our heads. 🙇🏼 |
|
Will this be merged any time soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including mixture of sync/async errors in lists
following #3706 fix for field execution