-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Fragment Arguments (a form of parameterized fragments) during execution #3152
Closed
Commits on Jan 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 90d048d - Browse repository at this point
Copy the full SHA 90d048dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94fef5d - Browse repository at this point
Copy the full SHA 94fef5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 914fd83 - Browse repository at this point
Copy the full SHA 914fd83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 938a983 - Browse repository at this point
Copy the full SHA 938a983View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76fb6a6 - Browse repository at this point
Copy the full SHA 76fb6a6View commit details
Commits on Jan 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 686fe56 - Browse repository at this point
Copy the full SHA 686fe56View commit details
Commits on Jan 6, 2023
-
polish: clarify filtering test semantics (graphql#3816)
`expect.fail()` was mistakenly introduced in graphql#3760 under the assumption that expect.fail() will always cause the test to fail, and that `.next()` should be called at most once. Actually, thought, `expect.fail()` just throws an error, `.next()` is called more than once, the error is produced and wrapped by GraphQL, but then it is filtered, so the test ultimately passes. Fortunately, that's actually the desired behavior! It's ok if the number of calls to `.next()` is more than 1 (in our case it is 2). The exact number of calls to `.next()` depends on the # of ticks that it takes for the erroring deferred fragment to resolve, which should be as low as possible, but that is a separate objective (with other PRs in the mix already aimed at reducing). So the test as written is intending to be overly strict, but is not actually meeting that goal and so functions as desires. This PR makes no change to the test semantics, but changes the comment, the coverage ignore statement, and removes the potentially confusing use of `expect.fail`, so that the test semantics are more clearly apparent.
Configuration menu - View commit details
-
Copy full SHA for 505d096 - Browse repository at this point
Copy the full SHA 505d096View commit details
Commits on Jan 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 19dba20 - Browse repository at this point
Copy the full SHA 19dba20View commit details -
Configuration menu - View commit details
-
Copy full SHA for a91fba8 - Browse repository at this point
Copy the full SHA a91fba8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87498db - Browse repository at this point
Copy the full SHA 87498dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for baa0e42 - Browse repository at this point
Copy the full SHA baa0e42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1af6fdf - Browse repository at this point
Copy the full SHA 1af6fdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for e0f432e - Browse repository at this point
Copy the full SHA e0f432eView commit details -
Merge branch 'fragment-args' of https://github.com/mjmahone/graphql-js …
…into fragment-args
Configuration menu - View commit details
-
Copy full SHA for 8724e22 - Browse repository at this point
Copy the full SHA 8724e22View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.