Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Fragment Arguments (a form of parameterized fragments) during execution #3152

Closed
wants to merge 14 commits into from

Commits on Jan 2, 2023

  1. Tests for fragment args

    mjmahone committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    90d048d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    94fef5d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    914fd83 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    938a983 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    76fb6a6 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Configuration menu
    Copy the full SHA
    686fe56 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. polish: clarify filtering test semantics (graphql#3816)

    `expect.fail()` was mistakenly introduced in graphql#3760 under the assumption that expect.fail() will always cause the test to fail, and that `.next()` should be called at most once.
    
    Actually, thought, `expect.fail()` just throws an error, `.next()` is called more than once, the error is produced and wrapped by GraphQL, but then it is filtered, so the test ultimately passes.
    
    Fortunately, that's actually the desired behavior! It's ok if the number of calls to `.next()` is more than 1 (in our case it is 2). The exact number of calls to `.next()` depends on the # of ticks that it takes for the erroring deferred fragment to resolve, which should be as low as possible, but that is a separate objective (with other PRs in the mix already aimed at reducing).
    
    So the test as written is intending to be overly strict, but is not actually meeting that goal and so functions as desires. This PR makes no change to the test semantics, but changes the comment, the coverage ignore statement, and removes the potentially confusing use of `expect.fail`, so that the test semantics are more clearly apparent.
    yaacovCR authored Jan 6, 2023
    Configuration menu
    Copy the full SHA
    505d096 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Tests for fragment args

    mjmahone committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    19dba20 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a91fba8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    87498db View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    baa0e42 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1af6fdf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e0f432e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8724e22 View commit details
    Browse the repository at this point in the history