separateOperations: stop unused fragments from being included#2853
Closed
filipstefansson wants to merge 1 commit intographql:masterfrom
Closed
separateOperations: stop unused fragments from being included#2853filipstefansson wants to merge 1 commit intographql:masterfrom
filipstefansson wants to merge 1 commit intographql:masterfrom
Conversation
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Nov 24, 2020
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Nov 24, 2020
Member
|
@filipstefansson Thanks for taking the time to report it and provide a solution. |
IvanGoncharov
added a commit
that referenced
this pull request
Nov 24, 2020
saihaj
pushed a commit
to saihaj/graphql-js
that referenced
this pull request
Jan 12, 2021
yaacovCR
pushed a commit
to yaacovCR/graphql-js
that referenced
this pull request
Apr 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
separateOperationsmethod sometimes include unused fragments if you name an operation the same thing as a fragment:When running
separateOperationson the above, and then looking at.Onesof the result, we get:This happens because in the dependency graph, there's nothing differentiating an operation from a fragment. They are just added by name. So in the scenario above the fragment
Onewill add the queryOneas a dependecy ofOnes, and then the queryOnehas the fragmentTwoas a dependency, so that will be added too.I fixed this by adding a prefix to the names in the dependecy graph, so operations can't be added a dependencies anymore, only fragments.