Skip to content

Removes default values for required fields in GraphQL*Config types #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2020
Merged

Removes default values for required fields in GraphQL*Config types #2328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/type/definition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ function defineFieldMap<TSource, TContext>(
| GraphQLInterfaceTypeConfig<TSource, TContext>,
>,
): GraphQLFieldMap<TSource, TContext> {
const fieldMap = resolveThunk(config.fields) || {};
const fieldMap = resolveThunk(config.fields);
devAssert(
isPlainObj(fieldMap),
`${config.name} fields must be an object with field names as keys or a function which returns such an object.`,
Expand Down Expand Up @@ -1147,7 +1147,7 @@ defineToJSON(GraphQLUnionType);
function defineTypes(
config: $ReadOnly<GraphQLUnionTypeConfig<mixed, mixed>>,
): Array<GraphQLObjectType> {
const types = resolveThunk(config.types) || [];
const types = resolveThunk(config.types);
devAssert(
Array.isArray(types),
`Must provide Array of types or a function which returns such an array for Union ${config.name}.`,
Expand Down Expand Up @@ -1430,7 +1430,7 @@ defineToJSON(GraphQLInputObjectType);
function defineInputFieldMap(
config: $ReadOnly<GraphQLInputObjectTypeConfig>,
): GraphQLInputFieldMap {
const fieldMap = resolveThunk(config.fields) || {};
const fieldMap = resolveThunk(config.fields);
devAssert(
isPlainObj(fieldMap),
`${config.name} fields must be an object with field names as keys or a function which returns such an object.`,
Expand Down