Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tstypes: Use any as BREAK type. #2135

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

JacksonKearl
Copy link

Otherwise, TS will reposrt errors when a visit function only conditionally returns BREAK (not all paths return a value error)

Otherwise, TS will reposrt errors when a visit function only conditionally returns BREAK (not all paths return a value error)
@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Aug 27, 2019
@IvanGoncharov IvanGoncharov changed the title Use any as BREAK type. tstypes: Use any as BREAK type. Aug 27, 2019
@IvanGoncharov IvanGoncharov merged commit 27e855a into graphql:master Aug 27, 2019
@IvanGoncharov
Copy link
Member

@JacksonKearl Thanks 👍

@jLouzado
Copy link

jLouzado commented Sep 3, 2019

was setting the type or null not an option? Then your visit function return type would be <type> | null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants