Sync type TS definitions with Flow #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: Add `extensions` field in lots of places Reorder fields Both this and graphql#2106 add Path.d.ts, but they're the same. If theres a merge conflict, just pick one.
|
This will need to wait until #2106 is in, then we can rebase off of it. Currently |
tstypes/type/scalars.d.ts
Outdated
| @@ -8,4 +8,4 @@ export const GraphQLID: GraphQLScalarType; | |||
|
|
|||
| export const specifiedScalarTypes: ReadonlyArray<GraphQLScalarType>; | |||
|
|
|||
| export function isSpecifiedScalarType(type: GraphQLScalarType): boolean; | |||
| export function isSpecifiedScalarType(type: unknown): type is GraphQLScalarType; | |||
There was a problem hiding this comment.
I thought unknown available only in TS 3.0?
tstypes/type/introspection.d.ts
Outdated
| @@ -40,6 +30,8 @@ export const SchemaMetaFieldDef: GraphQLField<any, any>; | |||
| export const TypeMetaFieldDef: GraphQLField<any, any>; | |||
| export const TypeNameMetaFieldDef: GraphQLField<any, any>; | |||
|
|
|||
| export const introspectionTypes: ReadonlyArray<any>; | |||
| export const introspectionTypes: ReadonlyArray< | |||
| GraphQLObjectType | GraphQLEnumType | |||
There was a problem hiding this comment.
I think it's better to make it just GraphQLType since we can latter add different types.
tstypes/type/definition.d.ts
Outdated
| @@ -285,13 +288,16 @@ export class GraphQLScalarType { | |||
| serialize: GraphQLScalarSerializer<any>; | |||
| parseValue: GraphQLScalarValueParser<any>; | |||
| parseLiteral: GraphQLScalarLiteralParser<any>; | |||
| extensions: Maybe<Record<string, any>>; | |||
There was a problem hiding this comment.
Can we make them ReadOnly both in class definitions and inside configs?
added 6 commits
August 23, 2019 10:07
|
@IvanGoncharov should be good to go now |
|
@JacksonKearl Merged 🎉 |
IvanGoncharov
added
the
PR: bug fix 🐞
This was referenced Sep 1, 2019
Merged
This was referenced Oct 26, 2019
This was referenced Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
Add
extensionsfield in lots of placesReorder fields
Both this and #2106 add Path.d.ts, but they're the same. If theres a merge conflict, just pick one.