Switch all 'for..of' loops to assume they iterating only arrays #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added
PR: bug fix 🐞
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Aug 20, 2019
Since graphql#2099 makes it zero-cost to use 'for..of' it's better to improve code readability and consistency
IvanGoncharov
added a commit
that referenced
this pull request
Aug 20, 2019
Since #2099 makes it zero-cost to use 'for..of' it's better to improve code readability and consistency
This was referenced Aug 31, 2019
Merged
Merged
This was referenced Oct 26, 2019
This was referenced Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2092