Convert more object types to be exact #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjmahone
reviewed
Aug 25, 2018
src/language/parser.js
Outdated
| @@ -70,7 +70,7 @@ import { DirectiveLocation } from './directiveLocation'; | |||
| /** | |||
| * Configuration options to control parser behavior | |||
| */ | |||
| export type ParseOptions = { | |||
| export type ParseOptions = {| | |||
There was a problem hiding this comment.
This may be a little dangerous, as I think there are places we do ParseOptions & { ... }, such as in buildASTSchema.
This would mean I can't create a generic const REPO_OPTIONS = { ... }; that could be used everywhere I call parse or buildASTSchema
There was a problem hiding this comment.
@mjmahone Good catch 👍
I missed that.
I reverted this change and change to buildASTSchema options.
IvanGoncharov
force-pushed
the
exactTypes
branch
from
f6c2292
to
494fae5
Compare
mjmahone
approved these changes
Aug 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No extremes only input types to help with detecting typos and similar to all other types in this lib.