Unify extending of type system #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
commented
Feb 22, 2018
| @@ -212,9 +181,6 @@ export function extendSchema( | |||
| const extendTypeCache = Object.create(null); | |||
|
|
|||
| // Get the root Query, Mutation, and Subscription object types. | |||
| // Note: While this could make early assertions to get the correctly | |||
| // typed values below, that would throw immediately while type system | |||
| // validation with validateSchema() will produce more actionable results. | |||
There was a problem hiding this comment.
This comment is not relevant anymore since they're no any cast here.
Moreover, the result of extending object type will always be an object type.
|
After a cursory read I think this looks great. However I'm going to hold off merging it while I'm investigating #1265 |
leebyron
reviewed
Feb 28, 2018
| // Note: While this could make early assertions to get the correctly | ||
| // typed values, that would throw immediately while type system | ||
| // validation with validateSchema() will produce more actionable results. | ||
| interfaces: interfaces ? () => (this.buildTypes(interfaces): any) : [], |
There was a problem hiding this comment.
Nice to avoid the lambda allocation if the AST defines no interfaces
|
Nice work |
This was referenced Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a preparation for the #1095