Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect added nullable input field or added nullable argument #1096

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

aolesky
Copy link

@aolesky aolesky commented Nov 20, 2017

T23304543

findBreakingChanges now includes checks for adding a nullable field to an existing input, and adding a nullable argument. These changes won't necessarily break a schema, but they can potentially cause issues. I also added unit tests for these new detections.

@leebyron
Copy link
Contributor

cc @sam-swarr @mjmahone - does this map to your understanding of potential issues?

@sam-swarr
Copy link
Contributor

@aolesky, thanks for writing this! The code looks great and ready to merge.

@leebyron, yep these are two good examples of cases that fall under potentially "dangerous" changes. Not technically breaking from the spec's perspective, but could cause issues if client code is not designed well. The diff looks good to me. I don't have the right privileges to accept it. Can you do that please?

@mjmahone
Copy link
Contributor

@leebyron yeah this is a good example. For instance, if your client code creates strict flow types for input objects, you may now need to update your client code when a nullable field is added to the input object.

@leebyron
Copy link
Contributor

leebyron commented Dec 1, 2017

@sam-swarr - you should be able to add yourself in the internal "oss" tool. I'll get this resolved and merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants