-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC break in minor release 14.5 #2190
Labels
Comments
@mrtnzlml Thanks for repo with reproduce 👍 |
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this issue
Sep 20, 2019
IvanGoncharov
added a commit
that referenced
this issue
Sep 20, 2019
@mrtnzlml Fixed in |
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this issue
Sep 20, 2019
Fixes graphql#2190 Port of graphql#2191 from `14.x.x` branch
IvanGoncharov
added a commit
that referenced
this issue
Sep 20, 2019
This was referenced Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi! I believe there is an unintentional backward compatibility break in version 14.5+ (works in 14.4). I created a repository where you can easily try it:
https://github.com/mrtnzlml/graphql-14.5-bc-break
The issue basically boils down to this query:
In version up to 14.4 you could run such query and it would be fine. But from 14.5 GraphQL throws this error:
It's probably because I am not sending any variables BUT there is a default value so I'd not expect it to throw. To be fair, I am not sure what is the correct behavior here. I can imagine a good reasoning for both. However, it's a BC break in a minor release which is probably not intentional (?). Didn't find much about it in the changelog.
I'd personally say it's a bug because there is a
name
arg value even though it's not passed in variables.The text was updated successfully, but these errors were encountered: