Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC break in minor release 14.5 #2190

Closed
mrtnzlml opened this issue Sep 20, 2019 · 2 comments · Fixed by #2192
Closed

BC break in minor release 14.5 #2190

mrtnzlml opened this issue Sep 20, 2019 · 2 comments · Fixed by #2192
Labels

Comments

@mrtnzlml
Copy link

mrtnzlml commented Sep 20, 2019

Hi! I believe there is an unintentional backward compatibility break in version 14.5+ (works in 14.4). I created a repository where you can easily try it:

https://github.com/mrtnzlml/graphql-14.5-bc-break

The issue basically boils down to this query:

query($name: String! = "MyName") {
    hello(name: $name)
}

In version up to 14.4 you could run such query and it would be fine. But from 14.5 GraphQL throws this error:

GraphQLError: Variable "$name" of required type "String!" was not provided.

It's probably because I am not sending any variables BUT there is a default value so I'd not expect it to throw. To be fair, I am not sure what is the correct behavior here. I can imagine a good reasoning for both. However, it's a BC break in a minor release which is probably not intentional (?). Didn't find much about it in the changelog.

I'd personally say it's a bug because there is a name arg value even though it's not passed in variables.

@IvanGoncharov
Copy link
Member

@mrtnzlml Thanks for repo with reproduce 👍
I will take a look at it.

@IvanGoncharov
Copy link
Member

@mrtnzlml Fixed in 14.5.7 📦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants