-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to prettify query variables input #990
Comments
Thanks for reporting this bug. We will be moving to a plugin that uses the
prettier module itself, thus we can rely on their algorithm to handle this
case. The current solution is flawed.
…On Tue, Oct 29, 2019 at 3:59 PM Ambro ***@***.***> wrote:
As a user it is really useful to prettify the input
query/mutation/suscription. But AFAIK there's currently no way to prettify
the query variables section.
If one follows the convention for mutations to receive a unique input
field, it becomes cumbersome when a mutation has many arguments as one has
to indent them manually.
[image: image]
<https://user-images.githubusercontent.com/11272260/67804231-540c9200-fa6d-11e9-8b46-07d17181c080.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#990?email_source=notifications&email_token=AAKOFF4VKO7HLZF3Q7RFNR3QRCI3BA5CNFSM4JGOU3Y2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HVF3FEQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKOFF6MCVGDUEEOPWPBOO3QRCI3BANCNFSM4JGOU3YQ>
.
|
In the mean time we could make our current prettify button change the variables to |
oh right that would be easy!
…On Thu, Oct 31, 2019 at 10:28 AM Benjie Gillam ***@***.***> wrote:
In the mean time we could make our current prettify button change the
variables to JSON.stringify(JSON.parse(text), null, 2); I’d be happy to
review a pull request that did this 👍
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#990?email_source=notifications&email_token=AAKOFF5YU7HNWZNEKJPLOJLQRLTSFA5CNFSM4JGOU3Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECX7HUA#issuecomment-548402128>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKOFF6UVAP2GNWYKYKZGPTQRLTSFANCNFSM4JGOU3YQ>
.
|
Thanks both for the fast reply. If I can be of any help testing/coding just ask |
@Ambro17 a PR doing this would be welcome. Try and make it as minimal as possible to encourage pain-free merging :) |
we have this discussion going now: #1517, and there's an RFC branch too! |
As a user it is really useful to prettify the input query/mutation/suscription. But AFAIK there's currently no way to prettify the query variables section.
If one follows the convention for mutations to receive a unique input field, it becomes cumbersome when a mutation has many arguments as one has to indent them manually.
The text was updated successfully, but these errors were encountered: