Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to prettify query variables input #990

Closed
Ambro17 opened this issue Oct 29, 2019 · 6 comments · Fixed by #991
Closed

Unable to prettify query variables input #990

Ambro17 opened this issue Oct 29, 2019 · 6 comments · Fixed by #991

Comments

@Ambro17
Copy link

Ambro17 commented Oct 29, 2019

As a user it is really useful to prettify the input query/mutation/suscription. But AFAIK there's currently no way to prettify the query variables section.
If one follows the convention for mutations to receive a unique input field, it becomes cumbersome when a mutation has many arguments as one has to indent them manually.

image

@acao
Copy link
Member

acao commented Oct 31, 2019 via email

@benjie
Copy link
Member

benjie commented Oct 31, 2019

In the mean time we could make our current prettify button change the variables to JSON.stringify(JSON.parse(text), null, 2); I’d be happy to review a pull request that did this 👍

@acao
Copy link
Member

acao commented Oct 31, 2019 via email

@Ambro17
Copy link
Author

Ambro17 commented Nov 1, 2019

Thanks both for the fast reply. If I can be of any help testing/coding just ask

@benjie
Copy link
Member

benjie commented Nov 6, 2019

@Ambro17 a PR doing this would be welcome. Try and make it as minimal as possible to encourage pain-free merging :)

@acao
Copy link
Member

acao commented Apr 29, 2020

we have this discussion going now: #1517, and there's an RFC branch too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants