fix(sonar-lint): 🐛 fixed doctype and missing html tags (#2835)

* fix(sonar-lint): 🐛 fixed doctype and missing html tags * Some HTML housekeeping * unaltered settings * refactor: 🔒 Added subresource integrity to unpkg cdn links * Update examples/graphiql-cdn/index.html Co-authored-by: Thomas Heyenbrock <[email protected]> * Update packages/graphiql/resources/index.html.ejs Co-authored-by: Thomas Heyenbrock <[email protected]> Co-authored-by: Thomas Heyenbrock <[email protected]>
graphql · Nov 25, 2022 · 6c3ca90 · 6c3ca90
1 parent 3f9a946
commit 6c3ca90
Show file tree

Hide file tree

Showing 7 changed files with 36 additions and 17 deletions.
diff --git a/examples/cm6-graphql-legacy-parcel/src/index.html b/examples/cm6-graphql-legacy-parcel/src/index.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <html lang="en">
   <head>
     <style>

diff --git a/examples/cm6-graphql-parcel/src/index.html b/examples/cm6-graphql-parcel/src/index.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <html lang="en">
   <head>
     <style>

diff --git a/examples/graphiql-cdn/index.html b/examples/graphiql-cdn/index.html
@@ -6,8 +6,9 @@
  *  LICENSE file in the root directory of this source tree.
 -->
 <!DOCTYPE html>
-<html>
+<html lang="en">
   <head>
+    <title>GraphiQL</title>
     <style>
       body {
         height: 100%;
@@ -29,12 +30,14 @@
       include them directly in your favored resource bundler.
     -->
     <script
-      crossorigin
       src="https://unpkg.com/react@17/umd/react.development.js"
+      integrity="sha512-Vf2xGDzpqUOEIKO+X2rgTLWPY+65++WPwCHkX2nFMu9IcstumPsf/uKKRd5prX3wOu8Q0GBylRpsDB26R6ExOg=="
+      crossorigin="anonymous"
     ></script>
     <script
-      crossorigin
       src="https://unpkg.com/react-dom@17/umd/react-dom.development.js"
+      integrity="sha512-Wr9OKCTtq1anK0hq5bY3X/AvDI5EflDSAh0mE9gma+4hl+kXdTJPKZ3TwLMBcrgUeoY0s3dq9JjhCQc7vddtFg=="
+      crossorigin="anonymous"
     ></script>
 
     <!--

diff --git a/examples/graphiql-parcel/src/index.html b/examples/graphiql-parcel/src/index.html
@@ -1,3 +1,4 @@
+<!DOCTYPE html>
 <html lang="en">
   <head>
     <style>

diff --git a/packages/graphiql-plugin-code-exporter/examples/index.html b/packages/graphiql-plugin-code-exporter/examples/index.html
@@ -6,8 +6,9 @@
  *  LICENSE file in the root directory of this source tree.
 -->
 <!DOCTYPE html>
-<html>
+<html lang="en">
   <head>
+    <title></title>
     <style>
       body {
         height: 100%;
@@ -32,21 +33,25 @@
     <div id="graphiql">Loading...</div>
 
     <script
-      crossorigin
       src="https://unpkg.com/react@17/umd/react.development.js"
+      integrity="sha512-Vf2xGDzpqUOEIKO+X2rgTLWPY+65++WPwCHkX2nFMu9IcstumPsf/uKKRd5prX3wOu8Q0GBylRpsDB26R6ExOg=="
+      crossorigin="anonymous"
     ></script>
     <script
-      crossorigin
       src="https://unpkg.com/react-dom@17/umd/react-dom.development.js"
+      integrity="sha512-Wr9OKCTtq1anK0hq5bY3X/AvDI5EflDSAh0mE9gma+4hl+kXdTJPKZ3TwLMBcrgUeoY0s3dq9JjhCQc7vddtFg=="
+      crossorigin="anonymous"
     ></script>
 
     <script
-      crossorigin
       src="https://unpkg.com/graphiql/graphiql.min.js"
+      integrity="sha512-FmqQBx9FVDKvUNDuimXswv4o1eqQUqzQYIuEoIkmkDaoXMUvmD9fKQXYSrSEMf5LQUEZr5EEMesxUzex2wS/hg=="
+      crossorigin="anonymous"
     ></script>
     <script
-      crossorigin
       src="https://unpkg.com/@graphiql/plugin-code-exporter/dist/graphiql-plugin-code-exporter.umd.js"
+      integrity="sha512-NwP+k36ExLYeIqp2lniZCblbz/FLJ/lQlBV55B6vafZWIYppwHUp1gCdvlaaUjV95RWPInQy4z/sIa56psJy/g=="
+      crossorigin="anonymous"
     ></script>
 
     <script>

diff --git a/packages/graphiql-plugin-explorer/examples/index.html b/packages/graphiql-plugin-explorer/examples/index.html
@@ -6,8 +6,9 @@
  *  LICENSE file in the root directory of this source tree.
 -->
 <!DOCTYPE html>
-<html>
+<html lang="en">
   <head>
+    <title></title>
     <style>
       body {
         height: 100%;
@@ -32,21 +33,25 @@
     <div id="graphiql">Loading...</div>
 
     <script
-      crossorigin
       src="https://unpkg.com/react@17/umd/react.development.js"
+      integrity="sha512-Vf2xGDzpqUOEIKO+X2rgTLWPY+65++WPwCHkX2nFMu9IcstumPsf/uKKRd5prX3wOu8Q0GBylRpsDB26R6ExOg=="
+      crossorigin="anonymous"
     ></script>
     <script
-      crossorigin
       src="https://unpkg.com/react-dom@17/umd/react-dom.development.js"
+      integrity="sha512-Wr9OKCTtq1anK0hq5bY3X/AvDI5EflDSAh0mE9gma+4hl+kXdTJPKZ3TwLMBcrgUeoY0s3dq9JjhCQc7vddtFg=="
+      crossorigin="anonymous"
     ></script>
 
     <script
-      crossorigin
       src="https://unpkg.com/graphiql/graphiql.min.js"
+      integrity="sha512-FmqQBx9FVDKvUNDuimXswv4o1eqQUqzQYIuEoIkmkDaoXMUvmD9fKQXYSrSEMf5LQUEZr5EEMesxUzex2wS/hg=="
+      crossorigin="anonymous"
     ></script>
     <script
-      crossorigin
-      src="https://unpkg.com/@graphiql/plugin-explorer/dist/graphiql-plugin-explorer.umd.js"
+      src="https://unpkg.com/@graphiql/plugin-code-exporter/dist/graphiql-plugin-code-exporter.umd.js"
+      integrity="sha512-NwP+k36ExLYeIqp2lniZCblbz/FLJ/lQlBV55B6vafZWIYppwHUp1gCdvlaaUjV95RWPInQy4z/sIa56psJy/g=="
+      crossorigin="anonymous"
     ></script>
 
     <script>

diff --git a/packages/graphiql/resources/index.html.ejs b/packages/graphiql/resources/index.html.ejs
@@ -6,8 +6,9 @@
  *  LICENSE file in the root directory of this source tree.
 -->
 <!DOCTYPE html>
-<html>
+<html lang="en">
   <head>
+    <title>GraphiQL</title>
     <style>
       body {
         height: 100%;
@@ -28,12 +29,14 @@
       include them directly in your favored resource bundler.
     -->
     <script
-      crossorigin
       src="https://unpkg.com/react@17/umd/react.development.js"
+      integrity="sha512-Vf2xGDzpqUOEIKO+X2rgTLWPY+65++WPwCHkX2nFMu9IcstumPsf/uKKRd5prX3wOu8Q0GBylRpsDB26R6ExOg=="
+      crossorigin="anonymous"
     ></script>
     <script
-      crossorigin
       src="https://unpkg.com/react-dom@17/umd/react-dom.development.js"
+      integrity="sha512-Wr9OKCTtq1anK0hq5bY3X/AvDI5EflDSAh0mE9gma+4hl+kXdTJPKZ3TwLMBcrgUeoY0s3dq9JjhCQc7vddtFg=="
+      crossorigin="anonymous"
     ></script>
 
     <!--